[PATCH] D84208: [PDB][NativeSession] Clean up some things in NativeSession.

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 21 16:00:03 PDT 2020


amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.

LGTM.

The naming improvements really help.  And it's nice to see the symbol tag set correctly (rather than generically only to be overridden).  Nice work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84208/new/

https://reviews.llvm.org/D84208





More information about the llvm-commits mailing list