[PATCH] D83404: [PowerPC][PCRelative] Thread Local Storage Support for Local Exec

[Victor Huang via Phabricator via llvm-commits]

NeHuang added inline comments.


================
Comment at: llvm/test/MC/PowerPC/pcrel-tls-local-exec-address-load-reloc.s:6
+
+# This test checks that on Power PC we can correctly convert x at tprel
+# into R_PPC64_TPREL34 for local exec relocations with address loaded
----------------
nit `x at TPREL`


================
Comment at: llvm/test/MC/PowerPC/pcrel-tls-local-exec-address-load-reloc.s:19
+	.type	LocalExec, at function
+LocalExec:                              # @LocalExec
+.Lfunc_begin0:
----------------
Please only keep the necessary assembly in the test and rename the function accordingly.


================
Comment at: llvm/test/MC/PowerPC/pcrel-tls-local-exec-value-load-reloc.s:6
+
+# This test checks that on Power PC we can correctly convert x at tprel
+# into R_PPC64_TPREL34 for local exec relocations with the value loaded
----------------
ditto


================
Comment at: llvm/test/MC/PowerPC/pcrel-tls-local-exec-value-load-reloc.s:19
+	.type	LocalExecLoad, at function
+LocalExecLoad:                          # @LocalExecLoad
+.Lfunc_begin0:
----------------
ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83404/new/

https://reviews.llvm.org/D83404