[PATCH] D84044: [AArch64][SVE] Add missing unwind info for SVE registers.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 21 15:02:44 PDT 2020


efriedma added a comment.

Oh, I missed that the IR declarations in the testcase were messing with the calling convention.

> The CFI entries only cover a subset of the SVE callee-saves and only encodes the lower 64-bits, thus implementing the lowest common denominator ABI. Existing unwinders may support VG but only restore the lower 64-bits.

I'm not sure I understand this.  If the calling convention requires saving the whole SVE register, unwinding needs to restore the entire SVE register, or else we corrupt the register in exception unwinding.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84044/new/

https://reviews.llvm.org/D84044





More information about the llvm-commits mailing list