[PATCH] D84038: Passing the flag bigobj globally when building debug compiler on Windows

[Chris Bieneman via Phabricator via llvm-commits]

beanz added a subscriber: rnk.
beanz added a comment.

Sadly I think @rnk isn't around. This is something I'd really like him to weigh in on. I assume there was a reason for doing this per-object file rather than for everything, and I don't have the context.



================
Comment at: llvm/CMakeLists.txt:603
 
+if (MSVC)
+   set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /bigobj")
----------------
aaron.ballman wrote:
> I would expect to find these changes in HandleLLVMOptions.cmake somewhere around line 390 (where we're setting up the other global MSVC flags), but I'm not the expert in our CMake. @beanz, what say you?
Yep. This should definitely be in `HandleLLVMOptions.cmake`, not the root CMakeLists.txt.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84038/new/

https://reviews.llvm.org/D84038