[PATCH] D84139: [Scheduling] Improve group algorithm for store cluster

[Evandro Menezes via Phabricator via llvm-commits]

evandro added a comment.

Other than that, it seems sensible.



================
Comment at: llvm/lib/CodeGen/MachineScheduler.cpp:1663
+           (Pred.getSUnit() && Pred.getSUnit()->getInstr()->mayStore()));
+      if (CtrlDepOnPred && !Pred.isArtificial()) {
         ChainPredID = Pred.getSUnit()->NodeNum;
----------------
It doesn't seem to me that the condition needs to be cached in a variable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84139/new/

https://reviews.llvm.org/D84139