[PATCH] D84228: [CodeGen][TargetPassConfig] Add unreachable-mbb-elimination pass explicitly

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 21 10:15:10 PDT 2020


ychen added a comment.

This is an unfortunate limit of legacy pass manager lacking runtime pass instrumentation support. NPM has better support of this.

Does this mean that we run UnreachableMachineBlockElimID twice? This new addPass and the old addRequiredID? Is it safe to remove the addRequiredID case?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84228/new/

https://reviews.llvm.org/D84228





More information about the llvm-commits mailing list