[PATCH] D67687: [NewPM][CodeGen] Introduce machine pass and machine pass manager

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 21 09:24:27 PDT 2020


ychen added a comment.

In D67687#2164285 <https://reviews.llvm.org/D67687#2164285>, @arsenm wrote:

> In D67687#2163365 <https://reviews.llvm.org/D67687#2163365>, @ychen wrote:
>
> > In the MIR pipeline (what this patch is about), the IR is not changed and not ran. So all IR analyses results are preserved in MIR pipeline. Modifying MIR could only invalidate MIR analysis results but not IR analyses results.
>
>
> This statement sounds too broad to me. For example, there may not be a 1:1 correspondence from MachineBasicBlock back to an IR BasicBlock, so any control flow analyses would be useless


Agree. But this does not contradict what I said? Do you mean this (`So all IR analyses results are preserved in MIR pipeline.`) is broad?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67687/new/

https://reviews.llvm.org/D67687





More information about the llvm-commits mailing list