[PATCH] D70174: [AArch64][SVE] Correctly allocate scavenging slot in presence of SVE.

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 21 04:20:56 PDT 2020


sdesmalen updated this revision to Diff 279479.
sdesmalen marked an inline comment as done.
sdesmalen retitled this revision from "[AArch64][SVE] Use FP for scavenging slot" to "[AArch64][SVE] Correctly allocate scavenging slot in presence of SVE.".
sdesmalen edited the summary of this revision.
sdesmalen added a comment.

- Changed condition to `useFPForScavengingIndex`
- Added new test `framelayout-scavengingslot.mir` to guard that stack realignment (without SVE) allocates the scavenging slot in the right place.
- Simplified patch, no need to refactor `estimateSVEStackObjectOffsets`
- Renamed misleading/wrong title of this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70174/new/

https://reviews.llvm.org/D70174

Files:
  llvm/lib/Target/AArch64/AArch64RegisterInfo.cpp
  llvm/test/CodeGen/AArch64/framelayout-scavengingslot.mir
  llvm/test/CodeGen/AArch64/framelayout-sve-basepointer.mir
  llvm/test/CodeGen/AArch64/framelayout-sve-scavengingslot.mir
  llvm/test/CodeGen/AArch64/framelayout-sve.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70174.279479.patch
Type: text/x-patch
Size: 7863 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200721/ca5dc435/attachment.bin>


More information about the llvm-commits mailing list