[PATCH] D83998: [flang][openacc] Basic name resolution infrastructure for OpenACC construct

[Brian Yang via Phabricator via llvm-commits]

ichoyjx requested changes to this revision.
ichoyjx added a comment.

Nice work on unifying two programming models' base attribute visitor. I am surprised that they could share most of the utils.

As you could see, the OpenMP part was a WIP work and I only added the `PreDetermined` attribute. In the future, `ExpDetermined` (explicitly) and `ImpDetermined` (implicitly) attributes are also needed. Besides, we have "Data Mapping Attribute" for OpenMP, which will increase the complexity too. Do you picture that `OpenACC` and `OpenMP` would work together without an issue using this framework?



================
Comment at: flang/lib/Semantics/resolve-names.cpp:1293
+  bool Pre(const parser::SpecificationPart &x) {
+    Walk(std::get<std::list<parser::OpenMPDeclarativeConstruct>>(x.t));
+    return false;
----------------
I believe this is a typo: `OpenMP`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83998/new/

https://reviews.llvm.org/D83998