[PATCH] D84208: [PDB][NativeSession] Clean up some things in NativeSession.

[Amy Huang via Phabricator via llvm-commits]

akhuang created this revision.
akhuang added reviewers: amccarth, hans.
Herald added subscribers: llvm-commits, rupprecht, MaskRay, hiraditya.
Herald added a reviewer: jhenderson.
Herald added a project: LLVM.
akhuang updated this revision to Diff 279374.
akhuang added a comment.

more cleanup


-Use the actual sect/offset to keep track of symbols in the cache so they don't get created multiple times with different addresses.
-Remove getSymTag from PDBFunctionSymbol/PDBPublicSymbol because it's already implemented in the base class
-Merge the symbolizer test files for DIA and native, since the tests are the same.
-Implement getCompilandId for NativeLineNumber


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D84208

Files:
  llvm/include/llvm/DebugInfo/PDB/Native/NativeFunctionSymbol.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativeLineNumber.h
  llvm/include/llvm/DebugInfo/PDB/Native/NativePublicSymbol.h
  llvm/include/llvm/DebugInfo/PDB/Native/SymbolCache.h
  llvm/lib/DebugInfo/PDB/Native/NativeFunctionSymbol.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeLineNumber.cpp
  llvm/lib/DebugInfo/PDB/Native/NativePublicSymbol.cpp
  llvm/lib/DebugInfo/PDB/Native/NativeSession.cpp
  llvm/lib/DebugInfo/PDB/Native/SymbolCache.cpp
  llvm/test/tools/llvm-symbolizer/pdb/pdb-columns.test
  llvm/test/tools/llvm-symbolizer/pdb/pdb-native-columns.test
  llvm/test/tools/llvm-symbolizer/pdb/pdb-native.test
  llvm/test/tools/llvm-symbolizer/pdb/pdb.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84208.279374.patch
Type: text/x-patch
Size: 13421 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200721/54e61f86/attachment-0001.bin>