[PATCH] D84199: GlobalISel: Add utilty for getting function argument live ins

[Matt Arsenault via Phabricator via llvm-commits]

arsenm created this revision.
arsenm added reviewers: aemerson, paquette, aditya_nandakumar, dsanders, hsmhsm, foad, mbrkusanin, Petar.Avramovic.
Herald added subscribers: kerbowa, hiraditya, kristof.beyls, tpr, rovka, nhaehnle, wdng, jvesely.
Herald added a project: LLVM.
arsenm added a child revision: D84203: AMDGPU/GlobalISel: Select llvm.returnaddress.
arsenm added a parent revision: D84198: AMDGPU/GlobalISel: Refactor special argument management.

Get the argument register and ensure there's a copy to the virtual
register. AMDGPU and AArch64 have similarish code to get the livein
value, and I also want to use this in multiple places.

      

This is a bit more aggressive about setting the register class than
the original function, but that's probably OK.

      

I think we're missing a few verifier checks for function live ins. I
noticed AArch64's calling convention code is not actually adding
liveins to functions, only the entry block (which apparently might 
not matter that much?). There should probably be a verifier
check that entry block live ins are also live into the function. We
also might need a verifier check that the copy to the livein virtual
register is in the entry block.


https://reviews.llvm.org/D84199

Files:
  llvm/include/llvm/CodeGen/GlobalISel/Utils.h
  llvm/lib/CodeGen/GlobalISel/Utils.cpp
  llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
  llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h
  llvm/test/CodeGen/AArch64/GlobalISel/select-returnaddress-liveins.mir
  llvm/test/CodeGen/AMDGPU/GlobalISel/irtranslator-call-implicit-args.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/irtranslator-call.ll
  llvm/test/CodeGen/AMDGPU/GlobalISel/legalize-addrspacecast.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84199.279337.patch
Type: text/x-patch
Size: 16929 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200721/289c1555/attachment-0001.bin>