[llvm] 21ef01b - AMDGPU: Remove outdated fixme

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 20 08:41:50 PDT 2020


Author: Matt Arsenault
Date: 2020-07-20T11:41:41-04:00
New Revision: 21ef01b7e36e13b6874c3f41888268e3e03bb248

URL: https://github.com/llvm/llvm-project/commit/21ef01b7e36e13b6874c3f41888268e3e03bb248
DIFF: https://github.com/llvm/llvm-project/commit/21ef01b7e36e13b6874c3f41888268e3e03bb248.diff

LOG: AMDGPU: Remove outdated fixme

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp b/llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
index 74e6f0c438b2..a63744200293 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
@@ -446,10 +446,8 @@ bool AMDGPUInstructionSelector::selectG_UADDO_USUBO_UADDE_USUBE(
                           I.getOpcode() == AMDGPU::G_USUBE;
 
   if (isVCC(Dst1Reg, *MRI)) {
-      // The name of the opcodes are misleading. v_add_i32/v_sub_i32 have unsigned
-      // carry out despite the _i32 name. These were renamed in VI to _U32.
-      // FIXME: We should probably rename the opcodes here.
-    unsigned NoCarryOpc = IsAdd ? AMDGPU::V_ADD_CO_U32_e64 : AMDGPU::V_SUB_CO_U32_e64;
+    unsigned NoCarryOpc =
+        IsAdd ? AMDGPU::V_ADD_CO_U32_e64 : AMDGPU::V_SUB_CO_U32_e64;
     unsigned CarryOpc = IsAdd ? AMDGPU::V_ADDC_U32_e64 : AMDGPU::V_SUBB_U32_e64;
     I.setDesc(TII.get(HasCarryIn ? CarryOpc : NoCarryOpc));
     I.addOperand(*MF, MachineOperand::CreateReg(AMDGPU::EXEC, false, true));


        


More information about the llvm-commits mailing list