[PATCH] D84071: More conservatively report status from LoopIdiomRecognize

[Jon Roelofs via Phabricator via llvm-commits]

jroelofs marked 2 inline comments as done.
jroelofs added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopIdiomRecognize.cpp:947
     // If we generated new code for the base pointer, clean up.
     RecursivelyDeleteTriviallyDeadInstructions(BasePtr, TLI);
+    return Changed;
----------------
nikic wrote:
> Pre-existing issue, but aren't we missing this for the early returns below? Probably this code should also use ExpandedValuesCleaner.
I'll take care of that in a follow-up commit: https://reviews.llvm.org/D84174


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84071/new/

https://reviews.llvm.org/D84071