[PATCH] D77550: [Matrix] Add TileInfo abstraction for tiled matrix code-gen.

[Florian Hahn via Phabricator via llvm-commits]

fhahn updated this revision to Diff 279230.
fhahn added a comment.

Thanks Adam! Added comments.

In D77550#2151655 <https://reviews.llvm.org/D77550#2151655>, @anemet wrote:

> BTW, will this be shared between .cpp's?  I.e. what is the justification for a header?


I guess they could in theory also be added directly to LowerMatrixIntrinsics.cpp. But I think it makes sense to have a separate file for various matrix-related utilities that are not directly tied to the intrinsics. I don't anticipate users outside of LowerMatrixIntrinsics.cpp anytime soon upstream, so I could also move them there. I think in the long-term we want to specify specialized, target-specific lowerings outside of LowerMatrixIntrinsics.cpp, so we might as well start with more generally accessible helpers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77550/new/

https://reviews.llvm.org/D77550

Files:
  llvm/include/llvm/Transforms/Utils/MatrixUtils.h
  llvm/lib/Transforms/Utils/CMakeLists.txt
  llvm/lib/Transforms/Utils/MatrixUtils.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D77550.279230.patch
Type: text/x-patch
Size: 8478 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200720/7808ff5f/attachment.bin>