[PATCH] D84163: AMDGPU/GlobalISel: Fix trying to widen <3 x s1> boolean ops

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:63
 
 static LegalityPredicate isSmallOddVector(unsigned TypeIdx) {
   return [=](const LegalityQuery &Query) {
----------------
Perhaps add a comment that "small" doesn't include s1 here?


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:73
+           EltSize > 1 && EltSize < 32 &&
            Ty.getSizeInBits() % 32 != 0;
   };
----------------
getSizeInBits will be (an odd number) * (a number less than 32), so I don't think it can ever be a multiple of 32. But I suppose it's harmless.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84163/new/

https://reviews.llvm.org/D84163