[PATCH] D84106: [llvm-readobj] Construct relocation-aware DWARFDataExtractor to decode .eh_frame addresses correctly

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 20 05:13:15 PDT 2020


grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

The description seems to be confusing, it says: "Use a relocation-aware DWARFDataExtractor instead of plain DataExtractor",
though both the code on the left and on the right use `DWARFDataExtractor` type and the difference is in the internal logic.

The rest looks fine to me (with a nit about headers order), I'd like somebody else to look at this too though.



================
Comment at: llvm/tools/llvm-readobj/DwarfCFIEHPrinter.h:26
 #include "llvm/Support/Format.h"
+#include "llvm/Support/ScopedPrinter.h"
 #include "llvm/Support/type_traits.h"
----------------
I think you could just add "DWARFContext.h", no need to sort the headers in this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84106/new/

https://reviews.llvm.org/D84106





More information about the llvm-commits mailing list