[PATCH] D82892: [NFC] Added comparision for all types in haveSameSpecialState() of Instruction.cpp

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 19 06:43:26 PDT 2020


nikic added inline comments.


================
Comment at: llvm/include/llvm/IR/InstrTypes.h:183
+  // so that the IR comparators stay in sync with the changes to IR.
+  int hasSamePropertiesAs(const UnaryOperator *I) const;
+
----------------
Now that this implements a comparison rather than an equality, the name is a bit odd. Maybe `compareProperties()` or so?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82892/new/

https://reviews.llvm.org/D82892





More information about the llvm-commits mailing list