[PATCH] D83738: [Attributor][WIP]Introduce call base context argument pathway.

Kuter Dinel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 19 00:41:29 PDT 2020


kuter marked 3 inline comments as done.
kuter added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:815
+    Worklist.push_back(V);
+  }
+
----------------
jdoerfert wrote:
> Style: No braces. Use a range loop or part of the constructor (or use append).
That was my initial idea but since `arg_begin()` is a pointer the `SmallVector` was trying to converyt `Argument` to `Value*`. After investigating I found that there is something called `pointer_iterator` that would fix this issue.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83738/new/

https://reviews.llvm.org/D83738





More information about the llvm-commits mailing list