[PATCH] D81929: [WIP][Attributor] Introduce CallBaseContext to the IRPosition

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jul 18 21:30:43 PDT 2020


jdoerfert added a comment.

All this is missing now is a test :). We can just check for the debug output.



================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:937
+#endif
+    IRP =
+        shouldPropagateCallBaseContext(IRP) ? IRP : IRP.stripCallBaseContext();
----------------
Nit: newline

Now we are in a hybrid solution, should we do `if (should...) IRP = ...` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81929/new/

https://reviews.llvm.org/D81929





More information about the llvm-commits mailing list