[PATCH] D83247: [compiler-rt][asan][hwasan] Refactor shadow setup into sanitizer_common (NFCI)

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 17 14:00:40 PDT 2020


phosek added a comment.

In D83247#2159463 <https://reviews.llvm.org/D83247#2159463>, @tejohnson wrote:

> Sorry about that! I see that this code when it was in asan before my patch was guarded by:
>  #if !SANITIZER_FUCHSIA && !SANITIZER_RTEMS
>  so probably I should guard it the same way here.
>
> Also, while the error above doesn't show any undefs coming from ProtectGap, I'm assuming that will give the same issue as it was moved to the same place and references MmapFixedNoAccess. Both were guarded before in asan and I'll add the guard here and commit shortly. I guess hwasan wasn't built on Fuchscia since it didn't have the guards around its version?


Not yet, we plan on porting HWASan to Fuchsia in the next few months.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83247/new/

https://reviews.llvm.org/D83247





More information about the llvm-commits mailing list