[PATCH] D84033: [llvm-readelf/readobj] - Refine the error reporting in printMipsABIFlags() methods.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 17 08:18:10 PDT 2020


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay, atanasyan.
Herald added subscribers: rupprecht, arichardson, sdardis, emaste.
Herald added a reviewer: espindola.
Herald added a project: LLVM.

It fixes/improves the following:

1. Some code was duplicated.
2. A "The .MIPS.abiflags section has a wrong size" error was not reported as a warning, but was printed to stdout for the LLVM style. Also, it was reported as an error for the GNU style. This patch changes the behavior to be consistent and to report warnings.
3. `unwrapOrError()` was used before, now a warning is reported instead.


https://reviews.llvm.org/D84033

Files:
  llvm/test/tools/llvm-readobj/ELF/mips-abiflags.test
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D84033.278776.patch
Type: text/x-patch
Size: 5718 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200717/cff61956/attachment.bin>


More information about the llvm-commits mailing list