[PATCH] D84010: AMDGPU/GlobalISel: Legalize s16->s64 G_FPTOSI/G_FPTOUI

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 17 06:59:24 PDT 2020


arsenm added a comment.

In D84010#2157971 <https://reviews.llvm.org/D84010#2157971>, @Petar.Avramovic wrote:

> This might be narrowScalar on TypeIndex==0 but it requires that s16 is at TypeIndex==1 thus I used custom legalize.


      

You can do
.narrowScalarIf(all(typeIs(0, S64), typeIs(1, S16)), changeTo(0, S32))

but we should have a narrowFor like the other actions

Also it might be worth fixing this in the DAG. It ends up with the huge expansion now


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84010/new/

https://reviews.llvm.org/D84010





More information about the llvm-commits mailing list