[PATCH] D83639: [OptTable] Support grouped short options

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 17 02:01:23 PDT 2020


grimar added a comment.

In D83639#2157629 <https://reviews.llvm.org/D83639#2157629>, @jhenderson wrote:

> Hesitant LGTM. I don't really follow much of the command line behaviour, so best wait for others to approve too.


I do not feel myself confident in accepting changes for the lib/Option code too. So +1 hesistant LGTM with the unaddressed nit resolved somehow.
(I've never saw "///" comments used for protected/private methods I think, I am not sure it worth documenting them so hard,
since they are not a part of a public API. So I'd expect the comment for the `parseOneArgGrouped` to be rewritten/reduced probably).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83639/new/

https://reviews.llvm.org/D83639





More information about the llvm-commits mailing list