[PATCH] D83935: [llvm-readobj] - Move out the common code from printRelocations() methods.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 17 00:15:31 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:5592
+                                             PrintRelaFn PrintRela,
+                                             PrintRelrFn PrintRelr) {
+  const Elf_Shdr *SymTab =
----------------
I am a bit unsure this simplifies the code (number of lines increased...).

We changed two dispatching switches to 3 lambdas plus 2 dispatching switches? Did not see how the new organization simplifies code or improves readability...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83935/new/

https://reviews.llvm.org/D83935





More information about the llvm-commits mailing list