[PATCH] D83976: [Mem2Reg] Teach promote to register about droppable instructions

Tyker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 16 12:17:26 PDT 2020


Tyker added a comment.

thank you for working on this



================
Comment at: llvm/lib/Transforms/Utils/PromoteMemoryToRegister.cpp:331
+    }
+
     if (!I->getType()->isVoidTy()) {
----------------
is there a reason you are not using dropDroppableUses here.

replacing uses in an assume by undef is usually not a safe transformation. perhaps there is UB is not exploited for operand bundles but it is very likely to be exploited for the usual boolean argument of assume.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83976/new/

https://reviews.llvm.org/D83976





More information about the llvm-commits mailing list