[PATCH] D83394: [AMDGPU] Avoid splitting FLAT offsets in unsafe ways

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp:1698
+        // into two pieces that are both >= 0 or both <= 0.
 
         SDLoc DL(N);
----------------
Can you add a fixme to check if this is needed if we know the address isn't FLAT_ADDRESS?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83394/new/

https://reviews.llvm.org/D83394