[PATCH] D82826: [X86] support .nops directive

Jian Cai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 15 15:22:48 PDT 2020


jcai19 added a comment.

In D82826#2154511 <https://reviews.llvm.org/D82826#2154511>, @MaskRay wrote:

> I think I have a very old (I emphasized it again in another comment) comment which isn't addressed (https://reviews.llvm.org/D82826#2126406 )
>  We should align with GNU as on the largest operand `.nops` supports.


I think it's probably better to address that in a separate patch as the this patch is focused on adding support to .nops directive, similar to this comment https://reviews.llvm.org/D82826?id=275853#inline-765965.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82826/new/

https://reviews.llvm.org/D82826





More information about the llvm-commits mailing list