[PATCH] D83744: [Attributor] Attributor call site specific AAValueConstantRange

[Kuter Dinel via Phabricator via llvm-commits]

kuter added a comment.

In D83744#2150057 <https://reviews.llvm.org/D83744#2150057>, @jdoerfert wrote:

> Cool! As discussed, merge D83299 <https://reviews.llvm.org/D83299> and add new call sites for test1.




In D83744#2154282 <https://reviews.llvm.org/D83744#2154282>, @sstefan1 wrote:

> In D83744#2153411 <https://reviews.llvm.org/D83744#2153411>, @kuter wrote:
>
> > merge with D83299 <https://reviews.llvm.org/D83299>
> >  add positive and negative tests.
> >
> > @jdoerfert I have a problem  with this patch even though I auto generate tests, llvm-lit fails.
> >  Is this a bug with the `update_test_checks.py` script ?
>
>
> Is the output of the script expected? Do all of them fail? Did you maybe specify the wrong opt binary?




In D83744#2154282 <https://reviews.llvm.org/D83744#2154282>, @sstefan1 wrote:

> In D83744#2153411 <https://reviews.llvm.org/D83744#2153411>, @kuter wrote:
>
> > merge with D83299 <https://reviews.llvm.org/D83299>
> >  add positive and negative tests.
> >
> > @jdoerfert I have a problem  with this patch even though I auto generate tests, llvm-lit fails.
> >  Is this a bug with the `update_test_checks.py` script ?
>
>
> Is the output of the script expected? Do all of them fail? Did you maybe specify the wrong opt binary?


I inspected the output that opt generates and it makes sense.
also the script's output (included in the patch) also makes sense the.

I will double check everything but this is weird.
File check fails to match the first check line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83744/new/

https://reviews.llvm.org/D83744