[PATCH] D83252: [XCOFF] Enable symbol alias for AIX

[Digger via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1406
+  // those labels.
+  if (TM.getTargetTriple().isOSBinFormatXCOFF()) {
+    assert(!isa<GlobalIFunc>(GIS) && "IFunc is not supported on AIX.");
----------------
DiggerLin wrote:
> jasonliu wrote:
> > jasonliu wrote:
> > > DiggerLin wrote:
> > > > change  if (TM.getTargetTriple().isOSBinFormatXCOFF() )
> > > > to 
> > > > if (TM.getTargetTriple().isOSBinFormatXCOFF() & IsFunction)
> > > > 
> > > > and we do no not need 
> > > > if (IsFunction) 
> > > > later
> > > I'm not sure how that would work because this if statement also intends to handle GlobalVariable. 
> > I mean alias to GlobalVariable. Not just Function.
> yes,  you are correct. the emitGlobalIndirectSymbol also been called for the GlobalObject too. 
sorry, the emitGlobalIndirectSymbol also been called for the GlobalVariable too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83252/new/

https://reviews.llvm.org/D83252