[PATCH] D83449: [llvm] Add contains(KeyType) -> bool methods to Set types.

Varun Gandhi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 15 12:07:53 PDT 2020


varungandhi-apple added a comment.

I've added some unit tests. Are these adequate/do you have any other suggestions on what I should test?

> might make sense to commit each one separately with its test

I'm not sure what benefit this would bring.  Could you elaborate? I would've understood if the combined change were large by itself, but that's not the case here.

> maybe some cleanup commits afterwards, to help migrate the codebase/encourage future use in the new direction

I could do this in a separate revision, if desired.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83449/new/

https://reviews.llvm.org/D83449





More information about the llvm-commits mailing list