[PATCH] D83834: Add test utility 'extract'

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/extract/extract.cpp:26
+
+static cl::OptionCategory cat("extract Options");
+
----------------
jhenderson wrote:
> Is there a way of telling clang-tidy to allow a different naming style?
Added `.clang-tidy` (like lldb/.clang-tidy and lld/.clang-tidy)


================
Comment at: llvm/tools/extract/extract.cpp:53
+static void handle(MemoryBuffer &inputBuf, StringRef input) {
+  const char *docBegin = nullptr, *docEnd = nullptr;
+  int numEmptyLines = 0;
----------------
jhenderson wrote:
> I might use `fileBegin` and `fileEnd`.
Changed to `partBegin`/`partEnd`. Hope that is clearer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83834/new/

https://reviews.llvm.org/D83834