[PATCH] D83748: Adding support for PCRel32GOTLoad in ELF x86 for the jitlinker

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 15 10:08:39 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp:409
         });
-
+        auto SymbolIndex = Rela.getSymbol(false);
         auto Symbol = Obj.getRelocationSymbol(&Rela, &SymTab);
----------------
https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable

Please spell out the exact type if it is non-obvious...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83748/new/

https://reviews.llvm.org/D83748





More information about the llvm-commits mailing list