[PATCH] D83520: [llvm-libtool-darwin] Allow flattening archives

[Sameer Arora via Phabricator via llvm-commits]

sameerarora101 marked 11 inline comments as done.
sameerarora101 added inline comments.


================
Comment at: llvm/test/tools/llvm-libtool-darwin/invalid-archive.test:9
+
+## Archive member not an object file:
+# RUN: rm -f %t.ar
----------------
jhenderson wrote:
> I take it this behaviour is taken from the original libtool?
Yup, cctools' libtool also throws an error for this case


================
Comment at: llvm/test/tools/llvm-libtool-darwin/valid-archive.test:7
+# RUN: rm -f %t.ar
+# RUN: rm -f %t.lib
+
----------------
jhenderson wrote:
> What's the reasoning for deleting `%t.lib` explicitly here?
Oh yeah, I don't need to do that as `llvm-libtool-darwin` overwrites it. Removed now. Thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83520/new/

https://reviews.llvm.org/D83520