[PATCH] D83745: [ARM] Optimize immediate selection

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 15 05:24:41 PDT 2020


SjoerdMeijer added reviewers: efriedma, dmgreen, samparker.
SjoerdMeijer added a comment.

I am not entirely sure anymore, but I thought I had looked into once, or at least something similar. I think the problem here is that if the constant is used only once like in the test, it is a clear win, but has soon as there are multiple uses than it's not better and probably worse. Also, with only one use, the code-size difference is neutral, but that won't be the case with multiple uses. So, I guess this work needs benchmark numbers, unless other reviewers that I've added can immediately tell if this is good or bad.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83745/new/

https://reviews.llvm.org/D83745





More information about the llvm-commits mailing list