[PATCH] D83862: [AMDGPU] Add missing test prefixes

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 15 04:26:57 PDT 2020


foad marked 2 inline comments as done.
foad added a comment.

This can't be committed as-is because some of the checks fail. @rampitec how should they be fixed? Should I just update the checks, or do we need to fix some real bugs?



================
Comment at: llvm/test/CodeGen/AMDGPU/perfhint.ll:33
 ; GCN-LABEL: {{^}}test_large_stride:
-; MemoryBound: 0
-; WaveLimiterHint : 1
+; GCN: MemoryBound: 0
+; GCN: WaveLimiterHint : 1
----------------
This check fails.


================
Comment at: llvm/test/CodeGen/AMDGPU/perfhint.ll:87
+; GCN: MemoryBound: 0
+; GCN: WaveLimiterHint : 0
 define amdgpu_kernel void @test_indirect_through_phi(float addrspace(1)* %arg) {
----------------
This check fails. Perhaps D47740 never worked?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83862/new/

https://reviews.llvm.org/D83862





More information about the llvm-commits mailing list