[PATCH] D83603: [lld-macho] Support __dso_handle for C++

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 15 01:36:54 PDT 2020


int3 marked an inline comment as done.
int3 added inline comments.


================
Comment at: lld/MachO/Symbols.h:121
+// The C++ ABI requires dylibs to pass a pointer to __cxa_atexit which does
+// e.g. cleanup of static global variables. The C++ spec says that the pointer
+// can point to any address in one of the dylib's segments, but in practice
----------------
pcc wrote:
> I don't think the "C++ spec" says anything about this. If anything, it would be the Itanium C++ ABI.
yeah I wasn't super sure what the right names for these things were -- I thought the document describing the ABI would be considered a spec -- but I guess 'spec' connotes 'language spec'...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83603/new/

https://reviews.llvm.org/D83603





More information about the llvm-commits mailing list