[PATCH] D83748: Adding support for PCRel32GOTLoad in ELF x86 for the jitlinker

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp:489
       for (auto SymRef : *Symbols) {
+        SymbolIndex++;
         auto Type = SymRef.getType();
----------------
LLVM coding style uses `++SymbolIndex`


================
Comment at: llvm/lib/ExecutionEngine/JITLink/ELF_x86_64.cpp:637
+      int64_t Value = E.getTarget().getAddress() + E.getAddend();
+      *(support::little64_t *)FixupPtr = Value;
+      break;
----------------
`llvm/Support/Endian.h` llvm::support::endian::write64le


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83748/new/

https://reviews.llvm.org/D83748