[PATCH] D83837: [LLVM] Fix handling of escaped closing brace `}` in `formatv` (under an option)

[Rahul Joshi via Phabricator via llvm-commits]

jurahul added a comment.

I ran into this issue when trying to attach default values to a parameter in the code generated by TableGen, which uses formatv(). Adding just {} does not work, so I thought {{}} should work based on the comments, but the code does not handle this. When testing, I found that there is a lot of existing code and tests that rely on this current (legacy) behavior, so decided to only enable the new mode optionally. Ideally, we should get rid of the legacy behavior, but it seems there are too many tests to fix (in clang, clangd etc), so I am not handling that with this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83837/new/

https://reviews.llvm.org/D83837