[PATCH] D83417: GlobalISel: Restructure argument lowering loop in handleAssignments

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 14 12:45:21 PDT 2020


aemerson added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/GlobalISel/call-lowering-i128-on-stack.ll:11
+define i32 @fn1(i32 %p1, i128 %p2, i32 %p3, i32 %p4, i32 %p5, i128 %p6, i32 %p7) {
+; CHECK-LABEL: fn1:
+; CHECK:       // %bb.0: // %entry
----------------
arsenm wrote:
> aemerson wrote:
> > This test is actually falling back to SDAG. If you add -global-isel-abort=1 it crashes.
> I think enabling the fallback is a bad default for llc
Probably true.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83417/new/

https://reviews.llvm.org/D83417





More information about the llvm-commits mailing list