[PATCH] D83785: [Matrix] Change the definitions of the load/store intrinsics

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 14 09:49:51 PDT 2020


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, thank you very much! This has been discussed already in D83477 <https://reviews.llvm.org/D83477>. Passing in a pointer to a vector is confusing, as it seems to suggest we only access elements of the vector pointer, but we may access other elements, if the stride > rows.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83785/new/

https://reviews.llvm.org/D83785





More information about the llvm-commits mailing list