[PATCH] D83624: [DWARFYAML] Implement the .debug_rnglists section.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Are we deliberately not supporting non-zero segment selector size values again? There's no test coverage for tables with non-zero values.



================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-rnglists.yaml:1
+## Test that yaml2obj emits .debug_rnglists section when requested.
+
----------------
emits -> emits a


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-rnglists.yaml:226-228
+##                                    ^-------                   version (2-byte)
+##                                             ^-------          offset_entry_count (4-byte)
+##                                                      ^------- offsets[0] (4-byte)
----------------
These comments look wrong. `Version` appears to be occupying four bytes, according to the `^-------`


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-rnglists.yaml:241
+      Version:          6
+      OffsetEntryCount: 4
+      Offsets:          [ 0x01 ]
----------------
I'd specify the AddrSize and segment selector size in this test too.


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-rnglists.yaml:259
+# ADDRSIZE32-NEXT: 0x00000010 05341200 00                         .4...
+##                            ^-                                  DW_RLE_base_address (1-byte)
+##                              ^--------                         operands[0] (4-byte)
----------------
You should probably test each of the address-using operands here to show they all use the right size, like you do in g).


================
Comment at: llvm/test/tools/yaml2obj/ELF/DWARF/debug-rnglists.yaml:371
+## j) Test that yaml2obj emits an error message if we specify invalid numbers of operands
+## to operator.
+
----------------
to operator -> for an operator


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83624/new/

https://reviews.llvm.org/D83624