[PATCH] D83682: [FileCheck] Add docs for --allow-empty

Tue Jul 14 01:25:46 PDT 2020

thopre added a comment.

In D83682#2149531 <https://reviews.llvm.org/D83682#2149531>, @jhenderson wrote:

> In D83682#2149473 <https://reviews.llvm.org/D83682#2149473>, @MaskRay wrote:
>
> > https://lists.llvm.org/pipermail/llvm-dev/2020-July/143344.html discusses --allow-empty, but I still don't get why we need --allow-empty.
>
>
> I think the idea is to prevent unexpected empty output from occurring in cases when --allow-empty is not specified. In a case where all a user cares about is that some string doesn't appear in the output, that might help make the test more robust (because they expect some output, just not what they specified), although honestly I'm not convinced, hence my proposal in the mailing list to change it to --expect-empty.

I think it could happen if you have a testcase that you wish to test the absence of a pattern in debug output. You might still want to compile the testcase in release mode if before a fix it used to segfault at compilation. So you'd have empty output in release mode and non empty output in debug mode. Just a thought though.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83682/new/

https://reviews.llvm.org/D83682