[PATCH] D83673: [DebugInfo] Add unit tests for DWARFListTableHeader::length().

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 13 16:48:05 PDT 2020


dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Looks good (one minor comment for a comment) - thanks!



================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFListTableTest.cpp:18
+TEST(DWARFListTableHeader, TruncatedLength) {
+  static const char SecData[] = "\x33\x22\x11";
+  DWARFDataExtractor Extractor(StringRef(SecData, sizeof(SecData) - 1),
----------------
maybe a comment "truncated DWARF32 length"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83673/new/

https://reviews.llvm.org/D83673





More information about the llvm-commits mailing list