[PATCH] D83721: [LLD] [MinGW] Ignore the --[no-]allow-shlib-undefined option

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo created this revision.
mstorsjo added reviewers: ruiu, amccarth, smeenai.
Herald added a subscriber: dang.
Herald added a project: LLVM.

GNU ld does accept this option when targeting PE-COFF, even though PE images clearly don't support leaving undefined symbols in a linked image.

Meson has earlier had issues where it tried to unconditionally pass this option when targeting a unix style linker (including the mingw target, which uses unix style options); currently meson tries to detect whether the option is supported and pass it.

For compatibility with GNU ld, just ignore this option, as there may be other projects out there that also blindly pass this option to the linker, even though it makes no sense for a windows target.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D83721

Files:
  lld/MinGW/Options.td


Index: lld/MinGW/Options.td
===================================================================
--- lld/MinGW/Options.td
+++ lld/MinGW/Options.td
@@ -103,6 +103,7 @@
 
 // Ignored options
 def: Joined<["-"], "O">;
+def: F<"allow-shlib-undefined">;
 def: F<"build-id">;
 def: F<"disable-auto-image-base">;
 def: F<"enable-auto-image-base">;
@@ -111,6 +112,7 @@
 def: F<"high-entropy-va">;
 def: S<"major-image-version">;
 def: S<"minor-image-version">;
+def: F<"no-allow-shlib-undefined">;
 def: F<"no-seh">;
 def: F<"nxcompat">;
 def: F<"pic-executable">;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83721.277570.patch
Type: text/x-patch
Size: 556 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200713/964aa7f3/attachment.bin>