[PATCH] D83703: [flang] Use octal escapes for character literals in modfiles

Tim Keith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 13 12:08:58 PDT 2020


tskeith marked 2 inline comments as done.
tskeith added inline comments.


================
Comment at: flang/lib/Semantics/mod-file.cpp:108
+
+ModFileWriter::~ModFileWriter() {
+  parser::useHexadecimalEscapeSequences = saveUseHexadecimalEscapeSequences_;
----------------
klausler wrote:
> Could use `common::Restorer` here instead of a flag and a destructor.
Good idea, I've done that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D83703/new/

https://reviews.llvm.org/D83703





More information about the llvm-commits mailing list