[PATCH] D81172: [AMDGPU] Implement hardware bug workaround for image instructions

Rodrigo Dominguez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 13 10:51:45 PDT 2020


rdomingu marked 2 inline comments as done.
rdomingu added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:3226-3228
+      // TODO Handle v3f16
+      if (StoreVT.getNumElements() == 3)
+        return Reg;
----------------
arsenm wrote:
> There's no obstacle to handling v3 here, it should work in the other cases
Note that v3f16 is not handled in SIISelLowering.cpp either (line 7255). Are you suggesting we implement v3f16 there too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81172/new/

https://reviews.llvm.org/D81172





More information about the llvm-commits mailing list