[PATCH] D82549: [AIX][XCOFF] parsing xcoff object file auxiliary header

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-readobj.rst:309
 
+XCOFF ONLY OPTIONS AND COMMANDS
+---------------------------------
----------------
nit: to match the naming convention in this file. 
XCOFF SPECIFIC OPTIONS


================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:142
+  support::ubig16_t SecNumOfTBSS;
+  support::ubig16_t XCOFF64bitsFlag;
+};
----------------
nit: If we want to keep the `bit` part. Then XCOFF64BitFlag. 


================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/xcoff-auxiliary-header.test:3
+RUN: llvm-readobj --auxiliary-headers %p/Inputs/xcoff-64-xlc-exec | \
+RUN:   FileCheck --check-prefix=XLC64EXEC %s
+
----------------
Should llvm-readobj --all print out the auxiliary headers?


================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:488
 
+void XCOFFDumper::printAuxiliaryHeaders(const XCOFFAuxiliaryHeader32 *AuxHeader) {
+  if (AuxHeader == nullptr) {
----------------
nit: Address clang-format comment.


================
Comment at: llvm/tools/llvm-readobj/XCOFFDumper.cpp:579
+  PrintAuxMember64(Number, "Section number for .tbss", SecNumOfTBSS);
+  PrintAuxMember64(Hex, "64 bits XCOFF Flag", XCOFF64bitsFlag);
+
----------------
hubert.reinterpretcast wrote:
> The adjective should be "64-bit". Also, these are only the additional XCOFF64 flags (and not all of the flags for XCOFF64).
> 
> Suggestion:
> Additional flags for 64-bit XCOFF
> 
nit: 
64 bits -> 64-bit


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82549/new/

https://reviews.llvm.org/D82549