[PATCH] D83683: [ms] [llvm-ml] Restore omitted changes requested by reviewer

[Eric Astor via Phabricator via llvm-commits]

epastor created this revision.
Herald added subscribers: llvm-commits, hiraditya.
Herald added a project: LLVM.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D83683

Files:
  llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
  llvm/test/tools/llvm-ml/struct.test


Index: llvm/test/tools/llvm-ml/struct.test
===================================================================
--- llvm/test/tools/llvm-ml/struct.test
+++ llvm/test/tools/llvm-ml/struct.test
@@ -156,6 +156,7 @@
       x BYTE ?
       y BYTE ?
     ENDS
+    after_struct BYTE ?
   ENDS
   z DWORD ?
 QUUX ENDS
@@ -166,6 +167,7 @@
 mov eax, [ebx].QUUX.w
 mov eax, [ebx].QUUX.x
 mov eax, [ebx].QUUX.y
+mov eax, [ebx].QUUX.after_struct
 mov eax, [ebx].QUUX.z
 
 ; CHECK: t9:
@@ -174,6 +176,7 @@
 ; CHECK-NEXT: mov eax, dword ptr [ebx + 4]
 ; CHECK-NEXT: mov eax, dword ptr [ebx + 4]
 ; CHECK-NEXT: mov eax, dword ptr [ebx + 5]
+; CHECK-NEXT: mov eax, dword ptr [ebx + 4]
 ; CHECK-NEXT: mov eax, dword ptr [ebx + 8]
 
 t10:
Index: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
===================================================================
--- llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
+++ llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
@@ -1657,7 +1657,7 @@
         if (NextTok.is(AsmToken::Identifier) &&
             NextTok.getIdentifier().equals_lower("ptr")) {
           SM.onCast(Identifier);
-          // eat type and ptr
+          // Eat type and PTR.
           consumeToken();
           End = consumeToken();
           break;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D83683.277434.patch
Type: text/x-patch
Size: 1250 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200713/885e6c0b/attachment.bin>