[PATCH] D79978: Call Frame Information (CFI) Handling for Basic Block Sections

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D79978#2146131 <https://reviews.llvm.org/D79978#2146131>, @tmsriram wrote:

> Let me try a slightly different approach here.  It is not clear to us what more is needed to land the patch.  In the interests of resolving conflict :
>
> 1. I will also explicitly test assembly too for callee saved registers with bb sections when they are being pushed and popped.


Just on this point - it's not clear to me the motivation for the difference in testing between the two tests (one testing assembly, the other testing LLVM's MIR) - was there some particular difference/detail that these different strategies enabled testing? Otherwise, yeah, I'd probably just go with only testing assembly in both cases, for consistency/simplicity? (any variation in tests always makes me wonder "what's the reason for this difference? Must be something important or they'd be the same and so I'm not understanding some important difference")


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79978/new/

https://reviews.llvm.org/D79978