[PATCH] D78741: [LLD][ELF][AVR] Implement the missing relocation types

Ayke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 12 03:17:11 PDT 2020


aykevl updated this revision to Diff 277282.
aykevl edited the summary of this revision.
aykevl added a comment.

- added `--print-imm-hex` (so this patch depends on D83634 <https://reviews.llvm.org/D83634>)
- deleted some redundant parentheses
- changed all comment markers to `;`

I've confirmed that `#` is not a valid comment char in the original AVR assembler. See: http://ww1.microchip.com/downloads/en/devicedoc/40001917a.pdf#page=12 (section 4.3). I don't know why `#` at the start of a line works as a comment, perhaps these lines are removed by llvm-lit?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78741/new/

https://reviews.llvm.org/D78741

Files:
  lld/ELF/Arch/AVR.cpp
  lld/test/ELF/avr-reloc.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78741.277282.patch
Type: text/x-patch
Size: 6618 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200712/cd5a5492/attachment.bin>


More information about the llvm-commits mailing list